Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect Appliance serial number from Sophos device #10210

Merged
merged 4 commits into from May 20, 2019

Conversation

Projects
None yet
4 participants
@corsoblaster
Copy link
Contributor

commented May 12, 2019

Add serial number read. Added on polling session instead of discovery because the S/N changes in case HA functionality is enabled, and there is a switch between active and standby.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Collect Appliance serial number from Sophos device
Add serial number read. Added on polling session instead of discovery because the S/N changes in case HA functionality is enabled, and there is a switch between active and standby.
@CLAassistant

This comment has been minimized.

Copy link

commented May 12, 2019

CLA assistant check
All committers have signed the CLA.

@label-actions

This comment has been minimized.

Copy link

commented May 12, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

Update cyberoam-utm.inc.php
You are right!
Sorry, it is my first time with Github. I pasted also the modification.
@corsoblaster
Copy link
Contributor Author

left a comment

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

It will take me some time, to clone the production into a test environment to make the tests

Show resolved Hide resolved includes/polling/os/cyberoam-utm.inc.php
@laf

This comment has been minimized.

Copy link
Member

commented May 14, 2019

If you can update the test data that would be ace. Should be as simple as

https://docs.librenms.org/Developing/os/Test-Units/#additional-module-support-or-test-data

corsoblaster added some commits May 19, 2019

@corsoblaster

This comment has been minimized.

Copy link
Contributor Author

commented May 19, 2019

Test files uploaded

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 3e2c999 into librenms:master May 20, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Collect Appliance serial number from Sophos device (librenms#10210)
* Collect Appliance serial number from Sophos device

Add serial number read. Added on polling session instead of discovery because the S/N changes in case HA functionality is enabled, and there is a switch between active and standby.

* Update cyberoam-utm.inc.php

@lock lock bot locked as resolved and limited conversation to collaborators Jul 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.