Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Cyberoam with Sophos (icon and logo) #10213

Merged
merged 3 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@corsoblaster
Copy link
Contributor

commented May 13, 2019

Cyberoam has been completely incorporated by Sophos since many years.
I'll try to replace everything related to Cyberoam, starting from logo and icon.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Replace Cyberoam with Sophos (icon and logo)
Cyberoam has been completely incorporated by Sophos since many years.
I'll try to replace everything related to Cyberoam, staring from logo and icon.
@corsoblaster

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

I need to upload sophos.png into logos and icon folder. How to do it?

Thanks

@murrant

This comment has been minimized.

Copy link
Member

commented May 13, 2019

If you are doing it from the webui, go to the files changed tab, click ... and edit file. Then click cancel, and browse to the http/images/os folder and click Upload files. Do the same for the logo :)

If using git on the CLI in your patch-2 branch, just git add http/images then git commit and git push

corsoblaster added some commits May 14, 2019

Updated Sophos logo
Updated Sophos logo
Added Sophos logo
Added Sophos logo
@corsoblaster

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

Files uploaded.

@murrant
Copy link
Member

left a comment

Thanks :)

@murrant murrant merged commit b58527c into librenms:master May 14, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Replace Cyberoam with Sophos (icon and logo) (librenms#10213)
* Replace Cyberoam with Sophos (icon and logo)

Cyberoam has been completely incorporated by Sophos since many years.
I'll try to replace everything related to Cyberoam, staring from logo and icon.

* Updated Sophos logo

Updated Sophos logo

* Added Sophos logo

Added Sophos logo

@murrant murrant added the Device 🖥 label May 28, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jul 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.