Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Laravel url helpers to improve functionality without dns name #10227

Merged
merged 3 commits into from May 20, 2019

Conversation

Projects
None yet
1 participant
@murrant
Copy link
Member

commented May 14, 2019

Not exhaustive...

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

murrant added some commits May 14, 2019

@murrant murrant removed the Needs Testing label May 20, 2019

@murrant murrant merged commit e9ae08d into librenms:master May 20, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:url-helpers branch May 20, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Use Laravel url helpers to improve functionality without dns name (li…
…brenms#10227)

* Use Laravel url helpers to improve functionality without dns name
Not exhaustive...

* Fix Url generated urls

* Bump js version

@lock lock bot locked as resolved and limited conversation to collaborators Jul 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.