Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make port counts match user expectations #10230

Merged
merged 1 commit into from May 19, 2019

Conversation

Projects
None yet
1 participant
@murrant
Copy link
Member

commented May 15, 2019

Fix disabled count
Consistent use of isNotDeleted

https://community.librenms.org/t/librenms-shows-port-down/8311

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Try to make port counts match users expectations
Fix disabled count
Consistent use of isNotDeleted

@murrant murrant changed the title Try to make port counts match users expectations Try to make port counts match user expectations May 15, 2019

@murrant murrant merged commit d6bb9f0 into librenms:master May 19, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:port-count-madness branch May 19, 2019

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Try to make port counts match users expectations (librenms#10230)
Fix disabled count
Consistent use of isNotDeleted

@lock lock bot locked as resolved and limited conversation to collaborators Jul 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.