Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArubaOS - fix client count polling, add ap count polling. #10231

Merged
merged 5 commits into from May 23, 2019

Conversation

Projects
None yet
4 participants
@twilley
Copy link
Contributor

commented May 15, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

- { graph: device_arubacontroller_numclients, text: 'Number of Clients' }
- { graph: device_wireless_ap-count, text: 'AP Count' }
- { graph: device_wireless_clients, text: 'Client Count' }
- { graph: device_arubacontroller_numaps, text: 'Number of APs (Legacy)' }

This comment has been minimized.

Copy link
@murrant

murrant May 16, 2019

Member

Is this worthwhile to leave? Maybe we should have a check if the rrd exists before displaying the overview graph?

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja May 16, 2019

Contributor

@murrant That would be nice indeed !

This comment has been minimized.

Copy link
@murrant

murrant May 19, 2019

Member

I took a look and it is not feasible with the current code. :( Would take some major re-writing of graphing. There is no way to know what rrd(s) it is in the code that generates the graph links.

@kkrumm1

This comment has been minimized.

Copy link
Member

commented May 16, 2019

I did a test on this with my controller. Worked great!

@kkrumm1 kkrumm1 added the Device 🖥 label May 16, 2019

@label-actions

This comment has been minimized.

Copy link

commented May 18, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@murrant
Copy link
Member

left a comment

Nice work @twilley

@murrant murrant merged commit a000b4a into librenms:master May 23, 2019

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@lock lock bot locked as resolved and limited conversation to collaborators Jul 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.