Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device groups showing multiple times #10247

Merged
merged 1 commit into from May 23, 2019

Conversation

Projects
None yet
1 participant
@murrant
Copy link
Member

commented May 22, 2019

Update hasAccess to not use a join.
Move into The Permissions facade so we only query the db once per page load for the permissions.
Fixes #10243

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix device groups showing multiple times.
Update hasAccess to not use a join.
Move into The Permissions facade so we only query the db once per page load for the permissions.

@murrant murrant merged commit 0807add into librenms:master May 23, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:device-group-hasaccess branch May 23, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jul 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.