Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance smart to show power_on_hours also #10261

Merged
merged 1 commit into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@SourceDoctor
Copy link
Contributor

commented May 24, 2019

Power on hours on smart will be monitored with this patch

@SourceDoctor

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

i think it's an useful enhancement for smart application :-)

@murrant

This comment has been minimized.

Copy link
Member

commented May 30, 2019

You can't modify the rrd defintion like that. rrds can't be changed after creation. The best way is to create a new rrd defintion just for that one data point.

@SourceDoctor

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2019

now new rrd for id9 enhancement will be created

@SourceDoctor

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@murrant something else to change for merging?

@murrant

murrant approved these changes Jun 7, 2019

Copy link
Member

left a comment

Looks good

@murrant murrant merged commit 349e102 into librenms:master Jun 7, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.