Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detection and sensors for Huawei SMU device #10267

Merged
merged 16 commits into from May 28, 2019

Conversation

Projects
None yet
2 participants
@jozefrebjak
Copy link
Contributor

commented May 26, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Tested on Huawei Site Monitor Unit SMU01A

It is good idea to set device sysName, sysLocation, sysContact through snmpset before adding them to LibreNMS.

jozefrebjak added some commits May 26, 2019

jozefrebjak added some commits May 26, 2019

@jozefrebjak jozefrebjak changed the title Added initial detection for Huawei SMU device Added detection and sensors for Huawei SMU device May 27, 2019

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

Update huawei-smu.inc.php
Force tests to run again
@PipoCanaja
Copy link
Contributor

left a comment

LGTM

Update huawei-smu.inc.php
Force test re-run
@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 824bcb7 into librenms:master May 28, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.