Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Quick Graphs bug w/ Aggregate 95th code #10269

Merged
merged 12 commits into from May 29, 2019

Conversation

Projects
None yet
2 participants
@llarian0
Copy link
Contributor

commented May 29, 2019

This is a fix for a bug introduced by #10202

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

llarian0 added some commits May 9, 2019

Added configuration options to aggregate input and output bits before…
… making 95th percentile billing calculations
Changed aggregate to per-bill instead of global. Added config options…
… for making aggregate the default selected option. Refactored out mres() calls in touched files. Changed to Config::get where appropriate.
Added configuration options to aggregate input and output bits before…
… making 95th percentile billing calculations
Changed aggregate to per-bill instead of global. Added config options…
… for making aggregate the default selected option. Refactored out mres() calls in touched files. Changed to Config::get where appropriate.

@murrant murrant merged commit 0e36e52 into librenms:master May 29, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.