Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French language support #10277

Merged
merged 6 commits into from Jun 21, 2019

Conversation

Projects
None yet
4 participants
@Cormoran96
Copy link
Contributor

commented May 30, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

Copy link

commented May 30, 2019

CLA assistant check
All committers have signed the CLA.

Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
@murrant

This comment has been minimized.

Copy link
Member

commented May 30, 2019

The current list of strings that should be translated in fr.json is here: https://p.libren.ms/view/796e4972

@murrant murrant added the Translation label Jun 3, 2019

Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated
Show resolved Hide resolved resources/lang/fr.json Outdated

@murrant murrant changed the title WIP - French language support French language support Jun 20, 2019

@murrant
Copy link
Member

left a comment

Merging pending translations.
Send new PR to update/expand.

@murrant murrant merged commit 6239db7 into librenms:master Jun 21, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.