Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIMC Version Fix #10284

Merged
merged 5 commits into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@djamp42
Copy link
Contributor

commented May 30, 2019

Old code was not working, and not even setting the correct variable.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

djamp42 added some commits May 30, 2019

Fix Software Version #
I don't think setting $firmware does anything, not to mention the regex wasn't matching correctly. I tested this fix tons of different software versions and they all seem to work.
@label-actions

This comment has been minimized.

Copy link

commented May 30, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@djamp42

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

I'm not sure what test's i can add, i'm not adding any new SNMP data, just regex the existing sysDescr for the version number.

@murrant

This comment has been minimized.

Copy link
Member

commented May 31, 2019

./scripts/collect-snmp-data.php -h

Then add the snmprec here. I'll capture the test data for the version string (among other things) ;)

@djamp42

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

Attached is a updated test data.

@murrant

murrant approved these changes Jun 4, 2019

@murrant murrant merged commit e514cbc into librenms:master Jun 4, 2019

5 of 6 checks passed

Travis CI - Pull Request Build Failed
Details
Inspection Summary
Details
Node: analysis
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.