Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show warning when ignored device is online (pingable) #10286

Merged
merged 3 commits into from May 30, 2019

Conversation

Projects
None yet
3 participants
@CirnoT
Copy link
Contributor

commented May 30, 2019

Current logic seems counter-intuitive - it shows gray color when ignored device is down and warning when ignored device is up. User should definitely not be shown warning when device is online - if anything it should be shown when device is offline, however that seems incorrect too since they chose to ignore this device. Further, device name is color-coded gray when ignored device is offline and green when ignored device is online which doesn't match with gray offline and yellow online colors for alert- and label- elements. This PR makes it so that ignored device is always shown as gray for label- and alert- elements in WebUI.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@kkrumm1 kkrumm1 added the WebUI label May 30, 2019

@murrant
Copy link
Member

left a comment

Looks good, seems like I blindly copied the existing logic :D

@murrant murrant merged commit 241b077 into librenms:master May 30, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.