Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB UI Changed color of Non Unicast Packets #10289

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
3 participants
@jozefrebjak
Copy link
Contributor

commented May 31, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

I believe that this PR helps to see better Non Unicast Packets on Port view.
Maybe we can use other colors maybe not.

Before:
image

After:
image

@murrant

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Odd that it doesn't use the any of our standard palettes. This looks fine to me.

@kkrumm1 kkrumm1 added the WebUI label Jun 3, 2019

@murrant

murrant approved these changes Jun 4, 2019

@murrant murrant added the Graphs label Jun 4, 2019

@murrant murrant merged commit bee4dbc into librenms:master Jun 4, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.