Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewritten device groups (including static) #10295

merged 24 commits into from Jun 16, 2019


None yet
1 participant
Copy link

commented Jun 2, 2019

This needs some testing since it is mostly new code.


  • Permissions to create, edit, and delete

Items to test:

  • Test adding editing and deleting in the webui. And editing old device groups (to test conversion).
  • Test that old device groups still work.
  • Test combining static and dynamic groups
  • Make sure polling isn't interrupted by any possible bugs
  • Test very complex rules

There are database changes, so you will have to run ./lnms migrate after applying


Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.


If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added this to the 1.53 milestone Jun 2, 2019

murrant added some commits May 31, 2019

Device Groups rewrite
Updated web ui
Static or dynamic groups allowed
Alert rule query builder
Translation support
Permissions support
Upgrade existing groups when editing.
Properly update only dynamic groups when polling.
remove unused old code
Update API and other places to use Eloquent
Fix up some things
creating static
improved validation
fix js error on creation
Fix static groups in polling
Implement authorization
Use in the menu too

@murrant murrant force-pushed the murrant:device-groups branch from f318a6f to 10bc8fc Jun 12, 2019

murrant added some commits Jun 12, 2019

More space in forms
Retain rules when converted to static
no duplicate names allowed

@murrant murrant removed the Needs Testing label Jun 13, 2019

murrant added some commits Jun 13, 2019

Better error feedback
Update related devices on save

@murrant murrant merged commit cfc51d5 into librenms:master Jun 16, 2019

5 of 6 checks passed

codeclimate 41 issues to fix
Inspection Summary
Node: analysis
Travis CI - Pull Request Build Passed
WIP Ready for review
license/cla Contributor License Agreement is signed.

@murrant murrant deleted the murrant:device-groups branch Jun 16, 2019

murrant added a commit that referenced this pull request Jun 17, 2019

@murrant murrant restored the murrant:device-groups branch Jun 17, 2019

murrant added a commit that referenced this pull request Jun 17, 2019

@murrant murrant referenced this pull request Jun 19, 2019


Device groups rewrite #10346

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.