Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlib link css class for changing background color - Update Url.php #10300

Merged
merged 4 commits into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@ckforum
Copy link
Contributor

commented Jun 3, 2019

Add css class "lib_overlib" onmouserover event for "overlib" link, easyer to change color of background ex.: for a dark theme vs bg color hardcoded

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Update Url.php
Ad css class to onmouserover event and overlib, easyer to change color of background ex.: for a dark theme vs bg color hardcoded
@CLAassistant

This comment has been minimized.

Copy link

commented Jun 3, 2019

CLA assistant check
All committers have signed the CLA.

@ckforum ckforum changed the title Update Url.php Add overlib css class for changing background color - Update Url.php Jun 3, 2019

@ckforum ckforum changed the title Add overlib css class for changing background color - Update Url.php Add overlib link css class for changing background color - Update Url.php Jun 3, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

You should include the css the sets the background to white too.

@kkrumm1 kkrumm1 added the WebUI label Jun 3, 2019

ckforum added a commit to ckforum/librenms that referenced this pull request Jun 3, 2019

Add class for overlib background see librenms#10300
class css for changing the background color of overlib instead of hardcoded color

ckforum added a commit to ckforum/librenms that referenced this pull request Jun 3, 2019

Add class for overlib background see librenms#10300
class css for changing the background color of overlib instead of hardcoded color

@ckforum ckforum referenced this pull request Jun 3, 2019

Closed

Add class for overlib background #10302

1 of 1 task complete
@ckforum

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

You should include the css the sets the background to white too.

Oops my bad, sorry first contribution :)
see #10302

murrant added some commits Jun 4, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

No worries. You can actually can edit additional files in this same PR. I've merged them for you.
I've changed the class name to something that made more sense to me, hope that is ok.

@murrant murrant dismissed their stale review via 85308b7 Jun 4, 2019

@murrant

murrant approved these changes Jun 4, 2019

@murrant murrant merged commit cafe057 into librenms:master Jun 4, 2019

3 of 5 checks passed

Travis CI - Pull Request Build Errored
Details
codeclimate Code Climate is analyzing this code.
Details
Inspection Summary
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@ckforum

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

great, thanks for your help murrant, it's ok for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.