Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change <h2></h1> ? by span and class like the other #10305

Merged
merged 2 commits into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@ckforum
Copy link
Contributor

commented Jun 4, 2019

replace bad tag h1 h2 by span and class to be in phase with the others link

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

change tab <h2></h1> ? by tab span and class like the other
replace bad tag h1 h2 by span and class to be in phase with the others link

@ckforum ckforum changed the title change tab <h2></h1> ? by tab span and class like the other change tab <h2></h1> ? by span and class like the other Jun 4, 2019

@ckforum ckforum changed the title change tab <h2></h1> ? by span and class like the other change <h2></h1> ? by span and class like the other Jun 4, 2019

@@ -94,7 +94,7 @@
$link = generate_url(array('page' => 'device', 'device' => $sensor['device_id'], 'tab' => $tab, 'metric' => $sensor['sensor_class']));
$overlib_content = '<div style="width: 580px;"><h2>'.$sensor['hostname'].' - '.$sensor['sensor_descr'].'</h1>';
$overlib_content = '<div style="width: 580px;"><span class="list-large">'.$sensor['hostname'].' - '.$sensor['sensor_descr'].'</span>';

This comment has been minimized.

Copy link
@murrant

murrant Jun 5, 2019

Member

It seems like overlib-text is a much more common class for this. Any reason you didn't use that?

This comment has been minimized.

Copy link
@ckforum

ckforum Jun 5, 2019

Author Contributor

hi murrant,
Why not, same values in these class

.list-large {
  font-size: 16px;
  font-weight: bold;
}

and

.overlib-text {
  font-weight: bold;
  font-size: 16px;
}

but you are right more logical because overlib 👍

i took exemple on

function onmouseover(event) {
  return overlib('<div class=\'overlib-contents\'><div><span class=\'list-large\' ...

in health/metric=storage/view=detail/

@murrant murrant added the WebUI label Jun 6, 2019

@murrant murrant merged commit 9dc6002 into librenms:master Jun 6, 2019

3 of 5 checks passed

Travis CI - Pull Request Build Errored
Details
codeclimate Code Climate is analyzing this code.
Details
Inspection Summary
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.