Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add power sensor for eaton ups #10306

Merged
merged 4 commits into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@StackOverBuffer
Copy link
Contributor

commented Jun 4, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

StackOverBuffer
@CLAassistant

This comment has been minimized.

Copy link

commented Jun 4, 2019

CLA assistant check
All committers have signed the CLA.

StackOverBuffer
@label-actions

This comment has been minimized.

Copy link

commented Jun 5, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

StackOverBuffer added some commits Jun 5, 2019

@StackOverBuffer

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

I have added the test data

@murrant murrant merged commit fec165f into librenms:master Jun 12, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.