Added Basic FiberHome Support #1031

Merged
merged 5 commits into from May 17, 2015

Projects

None yet

3 participants

@alangregory
Contributor

Added Os,Model and Firmware Version for fiberhome devices.

@laf
Member
laf commented May 17, 2015

Hi @alangregory

Thanks for the PR. Couple of things need updating before we can merge this:

  1. Can you remove the echo statements in the discovery and polling for the os please, -d to enable debug will already print this info out :)
  2. The inclusion of the temperature poller file isn't needed and shouldn't be done this way. The code slightly above for netapp is due to this needing custom parsing for temperatures. You can remove the includes/polling/temperatures/fibrehome.inc.php and update the includes/discovery/temperatures/fibrehome.inc.php to use the numerical OID instead of GEPON-OLT-COMMON-MIB::sysTemperature within discover_sensor(). Using the numerical OID means that when poll_sensor runs the snmp query is just done automatically and it doesn't need the MIB for lookup.

Hope this makes sense and thanks for submitting.

@alangregory
Contributor

Yes, it makes.

@f0o f0o added the New-Device label May 17, 2015
@laf laf merged commit 11d8e4b into librenms:master May 17, 2015

1 check passed

Scrutinizer 3 new issues
Details
@alangregory alangregory deleted the unknown repository branch May 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment