Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the Dell drac module to report CMC status and sensors #10310

Merged
merged 5 commits into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@daniviga
Copy link
Contributor

commented Jun 5, 2019

This PR maps sensors data from the Dell M1000e enclosure CMC.

This sensors are supported:

Temperature

Screenshot from 2019-06-05 14-27-18

Voltage

Screenshot from 2019-06-05 14-27-39

Current

Screenshot from 2019-06-05 14-27-47

Power

Screenshot from 2019-06-05 14-27-54

Sensors state

Screenshot from 2019-06-05 14-36-42

(some charts are empty because there's no enough data to plot)

I'm now working on test data, but before proceeding I would like to know from maintainers if the work done fits the workflow fro adding new sensors.

I'm also looking to add further information (like blades info).

Part of #9854

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

daniviga added some commits Jun 5, 2019

@daniviga

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

One question: I'm looking how to report the installed modules and blades, but they are not sensors. I guess they should be reported in the 'inventory' page, but how I can tell the discovery module to add items to the inventory?

I would anyway like to merge this PR and do the part related to the inventory in a separated PR.

daniviga added some commits Jun 5, 2019

@murrant murrant added the Device 🖥 label Jun 7, 2019

@murrant

murrant approved these changes Jun 7, 2019

Copy link
Member

left a comment

Looks good, Yeah I would put that info in the inventory section.

@murrant murrant merged commit c7228e3 into librenms:master Jun 7, 2019

5 of 6 checks passed

Travis CI - Pull Request Build Failed
Details
Inspection Summary
Details
Node: analysis
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@daniviga daniviga deleted the daniviga:dell-cmc branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.