Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example SNMP Trap handler class #10311

Merged
merged 2 commits into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@jozefrebjak
Copy link
Contributor

commented Jun 5, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

If you are adding trap handler for new OS, where are you using OS MIBs then you need to add MIB dir to your snmptrapd service, if it's using only MIBs from directory `/opt/librenms/mibs`.

```
ExecStart=/usr/sbin/snmptrapd -f -M /opt/librenms/mibs -m ALL

This comment has been minimized.

Copy link
@murrant

murrant Jun 6, 2019

Member

This conflicts with how our docs describe to set up snmptrapd. Perhaps we should just link to that with some extra notes: https://docs.librenms.org/Extensions/SNMP-Trap-Handler/#configure-snmptrapd

@murrant murrant changed the title Update SNMP-Traps.md Example SNMP Trap handler class Jun 12, 2019

@murrant murrant merged commit fd7defd into librenms:master Jun 12, 2019

3 of 5 checks passed

Travis CI - Pull Request Build Errored
Details
codeclimate Code Climate is analyzing this code.
Details
Inspection Summary
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.