Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 css class graph - minigraph for bg color and other #10318

Merged
merged 15 commits into from Jun 22, 2019

Conversation

Projects
None yet
2 participants
@ckforum
Copy link
Contributor

commented Jun 6, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

ckforum added some commits Jun 6, 2019

Add 2 class for graph / mini graph (styles.css)
Add 2 class for graph / mini graph (styles.css) 
for changing bg color and more (mini graph port / device) (graph port / general)
Update styles.css
Add 2 class for graph / mini graph (styles.css) 
for changing bg color and more (mini graph port / device) (graph port / general)
Add class CSS for mini graph
Add class CSS for mini graph
Merge pull request #2 from ckforum/ckforum-patch-1-1
Add class CSS for mini graph
Merge pull request #1 from ckforum/ckforum-patch-6-9
Add 2 class for graph / mini graph (styles.css)
@ckforum

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

@murrant Hello, as you wrote, i merged 3 changes from ckforum's fork to this PR (not easy to understand about the process i'm not familiar of git webui)

do i need to delete this other ? 10315, 10314, 10313 ? did i do the good things for you ?
Thanks

Update graph.inc.php
Change graph.inc.php, add css class / overlib
Show resolved Hide resolved html/css/styles.css Outdated

@murrant murrant added the WebUI label Jun 7, 2019

ckforum added some commits Jun 7, 2019

restore original bg #f5f5f5 .graph-all-common
restore original bg #f5f5f5 .graph-all-common
Update ports.inc.php
correct extra \
@ckforum

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

@murrant
Hi, I changed the items you reviewed, but I may not have done the right thing. you can see the changes in the "files changed" tab. Do you want to see again please? Thank you

Show resolved Hide resolved LibreNMS/Util/Url.php Outdated

ckforum added some commits Jun 16, 2019

Update Url.php
Line 88 -> re ident to pass travis...

@murrant murrant merged commit 342acf5 into librenms:master Jun 22, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.