Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Junos port/vlan relationships for els and non-els based software #10321

Merged
merged 8 commits into from Aug 28, 2019

Conversation

@Serazio
Copy link
Contributor

commented Jun 7, 2019

Hi,

i tried to fix port / vlan relationship detection for juniper based devices, as it wasnt working. For non-els based software it was only detecting untagged ports and for els based software just vlans.
Hopefully it will met all requirements, as i'm not a professional developer.

Result:
Bildschirmfoto 2019-06-07 um 14 06 18

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@label-actions

This comment has been minimized.

Copy link

commented Jun 7, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

Hi @Serazio
When adding the test-data, could you please create a variant (so the data you add does not break existing data)? Right now, both old data and the one you added got merged in some way.
Thanx

@laf laf removed the Needs Tests 🦄 label Jul 9, 2019

murrant added 4 commits Aug 8, 2019

@murrant murrant merged commit 142a1ab into librenms:master Aug 28, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.