Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ukrainian language support #10328

Merged
merged 4 commits into from Jun 20, 2019

Conversation

Projects
None yet
3 participants
@p4k8
Copy link
Contributor

commented Jun 9, 2019

Translated files in /resources/lang/ and added in uk.json lines from pastebin.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

p4k8 and others added some commits Jun 7, 2019

@murrant murrant added the Translation label Jun 12, 2019

@murrant
Copy link
Member

left a comment

Merging pending translations.
Send new PR to update/expand.

@murrant murrant merged commit 210529c into librenms:master Jun 20, 2019

5 of 6 checks passed

codeclimate 5 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Shouldn't this be UA: https://www.countrycode.org/ukraine

@p4k8

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

No, while UA is a country code, language code as per ISO is UK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.