Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort arrays before storing them in a component #10329

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@VVelox
Copy link
Contributor

commented Jun 10, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Quiets various messages about changes to components by sorting some arrays before storing them.

@murrant murrant merged commit d071c8b into librenms:master Jun 11, 2019

4 of 6 checks passed

Travis CI - Pull Request Build Failed
Details
codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.