Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Config class instead of global #10339

Merged
merged 1 commit into from Jun 23, 2019

Conversation

Projects
None yet
1 participant
@murrant
Copy link
Member

commented Jun 15, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the Refactor label Jun 15, 2019

@murrant murrant force-pushed the murrant:config-convert branch 2 times, most recently from 88c7b1d to 170d48c Jun 20, 2019

Use Config helper
remove usage of global variable

@murrant murrant force-pushed the murrant:config-convert branch from ea5749d to 78ae950 Jun 22, 2019

@murrant murrant merged commit f3ba894 into librenms:master Jun 23, 2019

3 of 4 checks passed

codeclimate 240 issues to fix
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:config-convert branch Jun 23, 2019

@murrant murrant referenced this pull request Jun 26, 2019

Merged

Fix broken updates #10380

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.