Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go through making lots of the docs more lint happy #10342

Merged
merged 27 commits into from Jun 20, 2019

Conversation

Projects
None yet
3 participants
@VVelox
Copy link
Contributor

commented Jun 17, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

No actual documentation changes. Went through making various formatting making mdl scream less about the.

Left the header start as they are, even though it does not fix issues with mdl not being happy with them as I am not sure if those are relevant or not off hand.

VVelox added some commits Jun 19, 2019

@murrant
Copy link
Member

left a comment

Looks good. Should we be adding a lint check to our build?

@murrant murrant merged commit 6575042 into librenms:master Jun 20, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@VVelox VVelox deleted the VVelox:mdclean branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.