Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI of filter menu #10348

Merged
merged 2 commits into from Jun 20, 2019

Conversation

Projects
None yet
3 participants
@JoshWeepie
Copy link
Contributor

commented Jun 19, 2019

In the current UI of the filter menu, it's not readily apparent that one, you are supposed to use the filter tabs, and two, that you need to refresh in order for the filter to apply. This request adds button colors to search, update, and reset to make the filter bar and action buttons stand out. See the proposed change below.

image

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Improve UI of filter menu
In the current UI of the filter menu, it's not readily apparent that one, you are supposed to use the filter tabs, and two, that you need to refresh in order for the filter to apply. This request adds button colors to search, update, and refresh to make the filter bar and action buttons stand out.

@kkrumm1 kkrumm1 added the WebUI label Jun 19, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Seems to call a little too much attention to it, maybe only colorize one button.

Only change search button color
Changed search button color to blue to fit in better
@JoshWeepie

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

image

@murrant
Copy link
Member

left a comment

Thanks @JoshWeepie

@murrant murrant merged commit 72de183 into librenms:master Jun 20, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.