Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Added VRP SFPs thresholds and map entPhysical to ifIndexes #10355

Merged
merged 3 commits into from Jun 22, 2019

Conversation

Projects
None yet
2 participants
@PipoCanaja
Copy link
Contributor

commented Jun 20, 2019

A little bug appeared in the discover entity function, as the ifIndex was not taken into account during updates, only during initial insert.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja changed the title WIP - Added VRP SFPs thresholds and map entPhysical to ifIndexes Added VRP SFPs thresholds and map entPhysical to ifIndexes Jun 20, 2019

PipoCanaja added some commits Jun 21, 2019

Update entity-physical.inc.php
Comment and force TravisTests

@PipoCanaja PipoCanaja changed the title Added VRP SFPs thresholds and map entPhysical to ifIndexes WIP - Added VRP SFPs thresholds and map entPhysical to ifIndexes Jun 21, 2019

@murrant murrant merged commit a3bb920 into librenms:master Jun 22, 2019

4 of 6 checks passed

codeclimate 1 issue to fix
Details
WIP Title contains "WIP"
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details

murrant added a commit that referenced this pull request Jun 22, 2019

murrant added a commit that referenced this pull request Jun 22, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

@PipoCanaja sorry, I didn't noticed you changed this to WIP, I reverted. Please resubmit.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

Yep, I am still testing it, seems that it could be improved on some devices. Re-opened it and will update you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.