Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an issue where the order may be random when adding values to the UPS-APC RRD #10375

Merged
merged 1 commit into from Jun 26, 2019

Conversation

Projects
None yet
3 participants
@VVelox
Copy link
Contributor

commented Jun 25, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

I have no clue what is going on here as correct data is returned, but this fixes the problem.

Came across while investigating librenms/librenms-agent#229 .

@VVelox VVelox referenced this pull request Jun 25, 2019

Closed

apcUPSd values mixed up #229

@kkrumm1 kkrumm1 added the Device 🖥 label Jun 25, 2019

@murrant murrant merged commit ad6ac30 into librenms:master Jun 26, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.