Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfdump support for with NFSen #10376

Merged
merged 13 commits into from Aug 7, 2019

Conversation

@VVelox
Copy link
Contributor

commented Jun 25, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

For those of you who are curious as to what this looks like.

image

Was originally #9987 , but that was a old one from when html moved to include/html and the merge did not totally go nicely.

@VVelox VVelox referenced this pull request Jun 25, 2019
1 of 1 task complete
includes/html/functions.inc.php Outdated Show resolved Hide resolved
includes/html/functions.inc.php Outdated Show resolved Hide resolved
includes/html/functions.inc.php Outdated Show resolved Hide resolved
includes/html/pages/device/nfsen/stats.inc.php Outdated Show resolved Hide resolved
includes/html/graphs/device/nfsen_common.inc.php Outdated Show resolved Hide resolved
@VVelox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

@murrant Howdy! All done with that. Sorry about the delay.

includes/html/functions.inc.php Outdated Show resolved Hide resolved
@laf

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Sounds petty but could you update the formatting where you've done something=nothing to something = nothing. Also for the html code OPTION to lower case option.

@VVelox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

@laf Sure. Null sweat. :)

I'll get it knocked out tonight.

VVelox added 3 commits Jul 4, 2019
@VVelox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

@laf All done. :)

@laf laf added the WebUI label Jul 9, 2019

@laf
laf approved these changes Jul 9, 2019
Copy link
Member

left a comment

LGTM. Can't test though

@murrant
murrant approved these changes Aug 7, 2019

@murrant murrant merged commit 0a6ded9 into librenms:master Aug 7, 2019

5 of 6 checks passed

codeclimate 9 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.