Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atuc chan curr tx rate/atur chan curr tx rate #10383

Merged
merged 5 commits into from Jun 30, 2019

Conversation

Projects
None yet
2 participants
@SniperVegeta
Copy link
Contributor

commented Jun 27, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

SniperVegeta added some commits Jun 27, 2019

Update adsl_speed.inc.php
Change AtucChanCurrTxRate and AturChanCurrTxRate

AtucChanCurrTxRate  = Downstream
AturChanCurrTxRate  = Upstream
Update adsl_snr.inc.php
AtucCurrSnrMgn = Down
AturCurrSnrMgn = Up
Update adsl_attainable.inc.php
AtucCurrAttainableR = Down
AturCurrAttainableR = Up
Update adsl_attenuation.inc.php
AtucCurrAtn = Down
AturCurrAtn =Up
@murrant
Copy link
Member

left a comment

Thanks, seems correct according to RFC 2662

@murrant murrant merged commit 242ab51 into librenms:master Jun 30, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.