Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown in Changelog #10387

Merged
merged 2 commits into from Jun 30, 2019

Conversation

Projects
None yet
4 participants
@N-Mi
Copy link
Contributor

commented Jun 27, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

N-Mi added some commits Jun 27, 2019

@CLAassistant

This comment has been minimized.

Copy link

commented Jun 27, 2019

CLA assistant check
All committers have signed the CLA.

@murrant
Copy link
Member

left a comment

Nice cleanup

@murrant murrant merged commit 5021eeb into librenms:master Jun 30, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@N-Mi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

Hello @murrant ,

Thanks for the merge.

Unfortunately, i seems the merge has been overwritten when you updated the file for the 1.53 release (you probably had started to edit the file before merging) :)

@murrant

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

@N-Mi It is generated by a script, but might have been something like that. Can you resubmit?

@N-Mi N-Mi referenced this pull request Jul 1, 2019

Merged

Re-submit of #10387 #10402

1 of 1 task complete

@N-Mi N-Mi deleted the N-Mi:patch-1 branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.