Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial/model/version polling for Sentry4 MIB #10432

Merged
merged 3 commits into from Aug 28, 2019

Conversation

@XioNoX
Copy link
Contributor

commented Jul 10, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Quite straightforward, copied the Sentry3.inc.php and updated the OIDs.
Tested on our instance.

@label-actions

This comment has been minimized.

Copy link

commented Jul 10, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Hi @XioNoX
Could you have a look at the testdata for this OS? This is necessary to ensure that LibreNMS is tested against regressions.
Thanx

@XioNoX

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

@PipoCanaja Added, let me know if anything else is needed!

@murrant murrant merged commit 7811227 into librenms:master Aug 28, 2019

5 of 6 checks passed

codeclimate Code Climate is analyzing this code.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.