Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move API routing to Laravel #10457

Merged
merged 59 commits into from Jul 29, 2019

Conversation

@murrant
Copy link
Member

commented Jul 23, 2019

Remove Slim dependency.
Fix a couple bugs:
authlog wasn't working at all
alert rules only accepted builder rules as a string instead of raw json.
alert rules docs also was wrong for the devices name

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant force-pushed the murrant:simple-api-test branch from ac623ed to a431320 Jul 29, 2019

@murrant murrant changed the title Move api routing to Laravel Move API routing to Laravel Jul 29, 2019

@murrant murrant merged commit 89fae9b into librenms:master Jul 29, 2019

5 of 6 checks passed

codeclimate 60 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:simple-api-test branch Jul 30, 2019

@murrant

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.