Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added definition for Cisco SB SG250X #10472

Merged
merged 2 commits into from Jul 31, 2019

Conversation

@PipoCanaja
Copy link
Contributor

commented Jul 29, 2019

closes #10468

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 10472
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja self-assigned this Jul 29, 2019

@PipoCanaja PipoCanaja added this to the 1.55 milestone Jul 29, 2019

@PipoCanaja PipoCanaja changed the title Added definition for Cisco SB SG250X WIP - Added definition for Cisco SB SG250X Jul 29, 2019

@PipoCanaja PipoCanaja changed the title WIP - Added definition for Cisco SB SG250X Added definition for Cisco SB SG250X Jul 29, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

Tested OK, ready for merge.

@murrant murrant merged commit bc550c9 into master Jul 31, 2019

7 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.