Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended RecoveryOS Definition #10475

Merged
merged 2 commits into from Jul 31, 2019

Conversation

@h-barnhart
Copy link
Contributor

commented Jul 30, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

I modified the the discovery yaml to also look for Unitrends hardware appliances based on model number. The snmpget now uses a regex so it should continue to work as it does currently, but also look for model numbers associated with physical hardware. Also included test data for a Unitrends model 8024S.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja changed the title RecoveryOS Definition Update Extended RecoveryOS Definition Jul 31, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Thanx for your patch @h-barnhart

@PipoCanaja PipoCanaja merged commit cefa9c0 into librenms:master Jul 31, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@h-barnhart h-barnhart deleted the h-barnhart:recoveryos-update branch Jul 31, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.