Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing FW and Serials in Dlink #10481

Merged
merged 5 commits into from Aug 2, 2019

Conversation

@hanserasmus
Copy link
Contributor

commented Aug 1, 2019

closes #10467
DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Note: The original OIDList code can be found in /includes/polling/os/vrp.inc.php. I was told to have a look at that file for the idea by @PipoCanaja in discord. Any copyright infringement was done by mistake and not by malicious intent.

hanserasmus added 2 commits Aug 1, 2019
Fixed line indentations as per Code Climate first report
Missed two incorrect line indentations.
@hanserasmus hanserasmus referenced this pull request Aug 1, 2019
2 of 2 tasks complete
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Hi @hanserasmus
Looks good. Could you also add test data to this PR, so we can improve regression tests ?

@label-actions

This comment has been minimized.

Copy link

commented Aug 1, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@hanserasmus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@PipoCanaja I have 13 different models of Dlink in my installm which I have done my tests on via bash. Do I need to execute tests for all 13 models?

@hanserasmus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

Had troubles with the test data generation. Sorry for the multiple commits. Hopefully all is there now.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Hi @hanserasmus
Thanx for your PR. And the good amount of test material you provided :)

@PipoCanaja PipoCanaja merged commit 1a54bdc into librenms:master Aug 2, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@hanserasmus hanserasmus deleted the hanserasmus:issue-10467 branch Aug 5, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.