Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update services.inc.php #10486

Merged
merged 3 commits into from Aug 2, 2019

Conversation

@SniperVegeta
Copy link
Contributor

commented Aug 2, 2019

Added clickabel link to Services
Added hover of the services status

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

SniperVegeta added 2 commits Aug 2, 2019
Update services.inc.php
Added clickabel link to Services 
Added hover of the services status
Update services.inc.php
cleanup travis
@kkrumm1

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Can you post a screenshot of what this change looks like?

@SniperVegeta

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

afbeelding

@SniperVegeta

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

i realy sometimes have no cleu what travis is whining about....

do you?

Update services.inc.php
Travis cleanup
@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 7e676b7 into librenms:master Aug 2, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja added the WebUI label Aug 2, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Thanx @SniperVegeta
Travis is enforcing some rules which may appear annoying sometimes but they also ensure that the coding style remains consistant, and helps to keep a good readability 👍

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.