Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inbit and outbit rate to auxiliary datastores. #10512

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@SteFletcher
Copy link
Contributor

commented Aug 11, 2019

This change allows for the ifInBit and ifOutBit rates to be captured in auxiliary datastores (Influx, Prometheus, graphite and opentsdb). We need this so that the data returned from these datastores reflects the same usage stats we see in the RRD file/graphs.

Specifically we use this to capture the peak port utilization of any given device.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

Copy link

commented Aug 11, 2019

CLA assistant check
All committers have signed the CLA.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja self-assigned this Aug 21, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Hi @SteFletcher
Thanx for your PR. Could you bring us some feedback about the change. Is it working correctly on your setup. Is it 'done' and ready to be merged or do you have other changes in mind ?
Thanx

@SteFletcher

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

Hi @PipoCanaja, we have the change rolled out across several instances ranging from LibreNMS v1.48 and v1.54. Is there anything in terms of test evidence I need to upload?

Here is an example image from one of our Grafana based Influx graphs and below it the query for outbits:
image

SELECT "ifInBits_rate" FROM "ports" WHERE ("hostname" = '' AND "ifName" = '') AND $timeFilter

Thanks

@PipoCanaja PipoCanaja merged commit c666af1 into librenms:master Sep 2, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

Hi @SteFletcher
Thanx for your PR. It is now merged in the master branch.
Bye

@murrant murrant added Polling and removed Needs Testing labels Sep 3, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@SteFletcher FYI, the reason this wasn't exported is all TSDB can calculate this. That is one of their core functions. But this does make it easier for people to access this that don't know how to set up the calculation, at the cost of storage.

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.