Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ.md #10513

Merged
merged 3 commits into from Aug 22, 2019

Conversation

@hanserasmus
Copy link
Contributor

commented Aug 12, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@sorano

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@hanserasmus

"if you would are adding all the support yourself" ??

@hanserasmus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

@hanserasmus

"if you would are adding all the support yourself" ??

Yeah sorry. Bad moment. Fixed now.

@@ -368,7 +368,10 @@ adding to /etc/snmp/snmpd.conf :

## <a name="faq8"> How do I add support for a new OS?</a>

Please see [Supporting a new OS](../Developing/Support-New-OS.md)
Please see [Supporting a new OS](../Developing/Support-New-OS.md) if you are adding all
the support yourself, i.e. writing all of the supporting code. If you are only able

This comment has been minimized.

Copy link
@murrant

murrant Aug 12, 2019

Member

I'd like to see this encourage people to write it themselves. Most of the time it isn't even code, just some yaml files. There is a huge backlog of device support because we don't have many users contributing device support for other users.

This comment has been minimized.

Copy link
@hanserasmus

hanserasmus Aug 13, 2019

Author Contributor

Understood, but we have to be realistic as well. The PR came from a discussion in Discord where a user was confused as to which tutorial to follow. Declared himself a newbie, and asked what he can do to improve. So even though for some it might only be "just some yaml files" for others it feels like a monumental task to accomplish, and they would rather not do anything than do something wrong. Laf suggested he update the docs to improve the wording regarding the differentiation between the 2 methods of adding new OS support.

@laf
laf approved these changes Aug 22, 2019

@laf laf merged commit a9658e1 into librenms:master Aug 22, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@hanserasmus hanserasmus deleted the hanserasmus:patch-1 branch Aug 23, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.