Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXOS can build FDB table too #10522

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@soto2080
Copy link
Contributor

commented Aug 14, 2019

  • NXOS can build FDB table with the same commands used in IOS/IOSXE
  • TESTED under SNMPv3, v2 should be fine

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

NXOS can build FDB table too
* NXOS can build FDB table with the same commands used in IOS/IOSXE
* TESTED under SNMPv3, v2 should be fine
@CLAassistant

This comment has been minimized.

Copy link

commented Aug 14, 2019

CLA assistant check
All committers have signed the CLA.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Hi @soto2080

Thanx for your Pull Request. I tested on snmpv2 and Nexus 5596, works well.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Do you have, by chance, a lab Nexus that could be used to generate the test data ?

@soto2080

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Do you have, by chance, a lab Nexus that could be used to generate the test data ?

unfortunately no, but since the data is not that sensitive , maybe we can just cut some data from production machine?

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

Yep, you can also do that, but it can be tricky, and the coherence of data may not be so easy to respect. Let me know your results.

@soto2080

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Yep, you can also do that, but it can be tricky, and the coherence of data may not be so easy to respect. Let me know your results.

But I don't understand what data I should provide with.
Is there any template?
In the test section, I don't see FDB table test.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

You can run ./scripts/collect-snmp-data.php -m fdb-table -v fdb -h <yourDevice> on the device, this should collect the OIDs. The resulting snmp file can be then "reduced" to a few mac addresses.

You can give it a try, and if you cannot make it, I'll have a look at it later.

@soto2080

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

./scripts/collect-snmp-data.php -m fdb-table -v fdb -h

I tried, but it's difficult as you said to strip info from production machine.
I am counting on you.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

OK. Let's merge it as is, I should have a pair of spare N5596 at some point this end of year.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 610afac into librenms:master Aug 18, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@soto2080 soto2080 deleted the soto2080:patch-1 branch Aug 19, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.