Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alert log status #10524

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@SniperVegeta
Copy link
Contributor

commented Aug 15, 2019

Alert OK's whont show / now fixed

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Update alert-log.pdf.inc.php
Alert OK's whont show / now fixed
@PipoCanaja
Copy link
Contributor

left a comment

LGTM, tested OK

@PipoCanaja PipoCanaja merged commit 57ae718 into librenms:master Aug 15, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

Thanx @SniperVegeta
Never used the feature, testing PR is a way to discover LibreNMS :)

@murrant murrant changed the title Update alert-log.pdf.inc.php Fix alert log status Aug 20, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.