Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically cleanup plugin-table from removed plugins #10533

Merged
merged 3 commits into from Aug 27, 2019

Conversation

@SourceDoctor
Copy link
Contributor

commented Aug 17, 2019

if a plugin was removed from plugin-directory it stays in plugin-table in database
this patch runs a scan function to remove this orphaned entries from database

SourceDoctor and others added 2 commits Aug 17, 2019
@laf
Copy link
Member

left a comment

Couple of small changes but aside from that, looks good.

@SourceDoctor

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@laf
travis says you included some grammar failures.
Is on this pull request something to do from my side before merging?

@murrant

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Just a typo, that is what travis is for ;)

@murrant murrant merged commit 2e2c329 into librenms:master Aug 27, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.