Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipv6_network_id query for `null` context_name #10544

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@garysteers
Copy link
Contributor

commented Aug 21, 2019

ipv6_addresses table was not correctly being populated with ipv6_network_id.

Found as all v6 ports became 'neighbors' on the port list screen of a device. (see below)
Screenshot 2019-08-21 at 12 22 37

Post-change this now correctly identifies interfaces in the same network.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

Copy link

commented Aug 21, 2019

CLA assistant check
All committers have signed the CLA.

@PipoCanaja PipoCanaja self-assigned this Aug 21, 2019

@garysteers

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@PipoCanaja I've updated the change to fix the copy and paste error.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM, thanx

@PipoCanaja PipoCanaja merged commit a1c8fe6 into librenms:master Aug 21, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja added the Bug 🐞 label Aug 21, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.