Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert About page to Laravel #10551

Merged
merged 3 commits into from Aug 24, 2019

Conversation

@Jellyfrog
Copy link
Member

commented Aug 22, 2019

Moved some stuff around also:
image

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@Jellyfrog Jellyfrog added the WebUI label Aug 22, 2019

@Jellyfrog Jellyfrog added this to TODO in Laravel Conversion Items via automation Aug 22, 2019

@Jellyfrog Jellyfrog requested a review from murrant Aug 22, 2019

@Jellyfrog Jellyfrog force-pushed the Jellyfrog:feature/about-blade branch from f591dc8 to 0455055 Aug 22, 2019

@Jellyfrog Jellyfrog force-pushed the Jellyfrog:feature/about-blade branch from 0455055 to 433b1ab Aug 22, 2019

@murrant murrant changed the title Convert About page to laravel Convert About page to Laravel Aug 22, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Was looking at the callback stuff and made it work :)

@murrant murrant merged commit 47e4641 into librenms:master Aug 24, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

Laravel Conversion Items automation moved this from TODO to Done Aug 24, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.