Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert opengear to YAML-based discovery, add some new sensors, add test data #10553

Merged
merged 6 commits into from Aug 27, 2019

Conversation

@martijn-schmidt
Copy link
Contributor

commented Aug 22, 2019

I've converted the PHP-based discovery for the opengear signal sensor to YAML-based, added some new sensors, and added test data. And it all worked without having to change PHP code for the YAML discovery functions - sometimes life is simple! :)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 10553
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@laf
Copy link
Member

left a comment

Looks good. Just a couple of things to change to avoid losing data for users. Sucks as named indexes are much better....

includes/definitions/discovery/opengear.yaml Outdated Show resolved Hide resolved
includes/definitions/discovery/opengear.yaml Outdated Show resolved Hide resolved
@martijn-schmidt

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

@laf thanks for the feedback, I've modified the YAML for those two sensors to use numbered rather than named indexes and also updated the test data to match this change.

@murrant murrant removed the User-Pending label Aug 27, 2019

@murrant
Copy link
Member

left a comment

Looks good

Resolved

@murrant murrant merged commit 3a891ba into librenms:master Aug 27, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate 2 fixed issues
Details
license/cla Contributor License Agreement is signed.
Details

@martijn-schmidt martijn-schmidt deleted the martijn-schmidt:opengear branch Aug 27, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.