Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AIX detection running std snmpd or net-snmp #10569

Merged
merged 7 commits into from Sep 2, 2019

Conversation

@fbourqui
Copy link
Contributor

commented Aug 29, 2019

fix issue #10199

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 10569
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@fbourqui

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

Travis CI, is complaining about :
OS dell-os10: Discovered storage data does not match that found in tests/data/dell-os10.json

This dell-os10 seems to be a network switch not sure why it's checked withing the storage module.

same Travis error in:
When sending email alerts use CRLF for windows clients #10563

@fbourqui fbourqui changed the title add AIX detection running std snmpd or net-snmp, fix#10199 add AIX detection running std snmpd or net-snmp, fix #10199 Aug 29, 2019

@fbourqui fbourqui changed the title add AIX detection running std snmpd or net-snmp, fix #10199 add AIX detection running std snmpd or net-snmp Aug 29, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

Hi @fbourqui
Thanx for your PR !
The storage test will be solved via #10574 . Then we'll be able to run tests on this one. After a quick look, it looks good.
Stay tuned.

@PipoCanaja PipoCanaja self-assigned this Sep 1, 2019

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit c73e9cb into librenms:master Sep 2, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate 1 fixed issue
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja changed the title add AIX detection running std snmpd or net-snmp Added AIX detection running std snmpd or net-snmp Sep 2, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

Hi @fbourqui
Thanx for your PR, and sorry for the delay with the Travis tests.
Happy monitoring :) !

@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.