Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing to-parameter in graphRows #10720

Closed
wants to merge 1 commit into from

Conversation

@feuerrot
Copy link
Contributor

feuerrot commented Oct 18, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Description

This PR fixes the same problem as #10600 when graphRows() is used to generate multiple graphs of the same type (e.g. https://librenms.example.org/device/device=41/tab=graphs/).

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Oct 19, 2019

This smells like it should be fixed at a lower level.

@feuerrot

This comment has been minimized.

Copy link
Contributor Author

feuerrot commented Oct 19, 2019

graphRow() calls Url::generate() to generate the link and I suppose URL::generate() wouldn't be the right place.

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Oct 20, 2019

Indeed, but to is not require in the url... the default to on a graph is now as far a I know.

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Nov 8, 2019

Closing due to no response. Feel free to respond and we can re-open.

@murrant murrant closed this Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.