Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check depedencies once in validate.php #11316

Merged
merged 2 commits into from Mar 23, 2020
Merged

Conversation

@murrant
Copy link
Member

murrant commented Mar 20, 2020

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

murrant added 2 commits Mar 20, 2020
@murrant murrant added the Bug 🐞 label Mar 20, 2020
@murrant

This comment has been minimized.

Copy link
Member Author

murrant commented Mar 20, 2020

Fixes errors on ports and possible docker installs.

@dlangille

This comment has been minimized.

Copy link
Contributor

dlangille commented Mar 21, 2020

FYI, this helps my issue:

[root /usr/local/www/librenms]# ./validate.php 
sh: git: not found
sh: git: not found
====================================
Component | Version
--------- | -------
LibreNMS  | 1.61
DB Schema | 2020_02_10_223323_create_alert_location_map_table (159)
PHP       | 7.2.28
MySQL     | 5.7.29-log
RRDTool   | 1.7.2
SNMP      | sh: /usr/bin/snmpget: not found
====================================
Copy link
Member

Jellyfrog left a comment

LGTM

@murrant murrant merged commit 67f3d88 into librenms:master Mar 23, 2020
6 checks passed
6 checks passed
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@murrant murrant deleted the murrant:check-deps-once branch Mar 23, 2020
@murrant

This comment has been minimized.

Copy link
Member Author

murrant commented Apr 1, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-62-release-changelog-march-2020/11423/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.