BGP Polling: Add error code management #11424
Conversation
|
I am adding the missing test data |
kedare
force-pushed
the
bgp-last-error
branch
2 times, most recently
from
cd05517
to
dd1042f
Compare
Jellyfrog
added
Polling
Needs Tests 🦄
|
Please add test data so we can ensure your change is not broken in the future. Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units |
|
I am still adding test data, I suppose I can just add blank data like most of the other values ? (new fields to Null) as I can't add real test data. |
kedare
force-pushed
the
bgp-last-error
branch
4 times, most recently
from
6778586
to
7e36787
Compare
|
Tests passed, I can't do much for the code climate issues however ? |
database/migrations/2020_04_13_150500_add_last_error_fields_to_bgp_peers.php
Outdated
Show resolved
Hide resolved
|
Looks good, just some improvements. It might be a good idea to include some updated test data with the new fields. They seem to all be null. |
|
For the test data I could potentially add some for Arista, JunOS, and IOS-XR, but I will have to add it by hand on the test data, it's not very clear how to do that on the snmp test data ? |
kedare
changed the title
kedare
changed the title
|
Inserting additional data into existing snmprec files can be tricky. If you do it by hand, make sure the oid is always increasing. |
|
Maybe it would be more interesting to let someone that has a lab environment to add new test data ? I don't have access to non-production environment and I am not allowed to dump data from production for the tests (for the risk of leaking data) |
|
It would be good to have at least one with test data. You could manually add the oids, but that seems a little tedious. |
|
@kedare @murrant There is exist repo with snmpsim test data, i didn't checked it myself, but maybe it contain something useful for cases like this - https://github.com/etingof/snmpsim-data/tree/master/data/network/router |
|
I added some test data, let me know if this is enough |
murrant
removed
the
Needs Tests 🦄
|
Thanks @kedare , nice work :) |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/v1-63-release-changelog-april-2020/11828/1 |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
* BGP Polling: Add error code polling * Rework describe_bgp_error_code and fix bgp error fields migration * Add real test data for IOS-XR and Arista EOS
DO NOT DELETE THIS TEXT
Poll BGP errors codes from devices (Tested on IOS XR, JunOS, Arista EOS)
Display them on the routing pages
First line of status is generated from the error codes and subcodes (if supported)
The second line is that the device return as error text (if supported)
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.